From ce5a260bf034973a9bede07988ce994b532e2913 Mon Sep 17 00:00:00 2001 From: aho Date: Wed, 13 May 2020 09:57:33 +0200 Subject: [PATCH] Add TODO and NOTE about character selectors and * expression --- R/Start.R | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/R/Start.R b/R/Start.R index 3c544a4..f4d4c0f 100644 --- a/R/Start.R +++ b/R/Start.R @@ -930,6 +930,8 @@ Start <- function(..., # dim = indices/selectors, .FindTagValue(path_with_globs_and_tag, found_file, u_file_dim)) } + +#TODO: selector_checker() doesn't allow selectors to be characters. For selectors like "member = 'r7i1p1f1", it cannot be defined with values. dat_selectors[[u_file_dim]][[j]] <- selector_checker(selectors = selectors, var = unique(parsed_values), return_indices = FALSE) @@ -943,6 +945,10 @@ Start <- function(..., # dim = indices/selectors, } #print("I") } else { + +#NOTE: If there is no non-explicitly defined dim, use the first found file +# to modify. Problem: '*' doesn't catch all the possible file. Only use +# the first file. dat[[i]][['path']] <- .ReplaceGlobExpressions(dat[[i]][['path']], first_file, replace_values, defined_file_dims, dat[[i]][['name']], path_glob_permissive) } -- GitLab