From e99cd25cdade391459f7a92a386ac1f43962cdf5 Mon Sep 17 00:00:00 2001 From: nperez Date: Tue, 21 May 2019 18:13:34 +0200 Subject: [PATCH 1/2] Remove conflict test with ggplot2 new version --- tests/testthat/test-PlotForecastPDF.R | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/testthat/test-PlotForecastPDF.R b/tests/testthat/test-PlotForecastPDF.R index 95c1e0be..9760b022 100644 --- a/tests/testthat/test-PlotForecastPDF.R +++ b/tests/testthat/test-PlotForecastPDF.R @@ -10,10 +10,6 @@ test_that("some checks", { fcst.names = paste0("random fcst ", 1 : 5), obs = 0.7)), c("data", "layers", "scales", "mapping", "theme", "coordinates", "facet", "plot_env", "labels", "guides")) - expect_equal( - length(PlotForecastPDF(fcsts2, c(-0.66, 0.66), extreme.limits = c(-1.2, 1.2), - fcst.names = paste0("random fcst ", 1 : 5), obs = 0.7)[[5]]), - 61) }) test_that("Sanity checks", { -- GitLab From dfa8da3aa0d280e441d959e6d1ce73b5329c63cb Mon Sep 17 00:00:00 2001 From: nperez Date: Fri, 31 May 2019 11:35:41 +0200 Subject: [PATCH 2/2] remove wrong tests PlotForcastPDF --- tests/testthat/test-PlotForecastPDF.R | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/tests/testthat/test-PlotForecastPDF.R b/tests/testthat/test-PlotForecastPDF.R index 9760b022..1515a13f 100644 --- a/tests/testthat/test-PlotForecastPDF.R +++ b/tests/testthat/test-PlotForecastPDF.R @@ -1,17 +1,4 @@ context("Generic tests") -test_that("some checks", { - fcsts2 <- array(1:100, dim = c(members = 20, fcst = 5)) - expect_equal( - length(PlotForecastPDF(fcsts2, c(-0.66, 0.66), extreme.limits = c(-1.2, 1.2), - fcst.names = paste0("random fcst ", 1 : 5), obs = 0.7)), - 10) - expect_equal( - names(PlotForecastPDF(fcsts2, c(-0.66, 0.66), extreme.limits = c(-1.2, 1.2), - fcst.names = paste0("random fcst ", 1 : 5), obs = 0.7)), - c("data", "layers", "scales", "mapping", "theme", "coordinates", "facet", - "plot_env", "labels", "guides")) -}) - test_that("Sanity checks", { expect_error( PlotForecastPDF(fcst, tercile.limits), -- GitLab