The time period of the archive file currently depends on submit or start
time and whether the purge period is in hours, days, or months.
Previously, if the archive file name already exists, we would overwrite
the old archive file with the assumption that these are duplicate
records being archived after an archive load. However, that could result
in lost records in a couple of ways:

  * If there were runaway jobs that were part of an old archive file's
  time period and are later fixed and then purged, the old file would
  be overwritten.
  * If jobs or steps are purged but there are still jobs or steps in
  that time period that are pending or running, the pending or running
  jobs and steps won't be purged. When they finish and are purged, the
  old file would be overwritten.

Instead of overwriting the old file, we append a number to the file name
to create a new file. This will also be important in an upcoming commit.

Bug 6033.

When tres_usage_in_max field is empty it is recorded as '' in the database
which leads find_tres_count_in_string() to return an INFINITE64. Seff treats
INIFINITE64 as a valid value. This patch fixes this issue.

Bug 6817

Bug 6880/6952.

On requeue, the origin cluster job record is copied to submit
to sibling clusters. If the job was originally submitted
to accept cluster default account, partition, etc, those fields
are now filled in on the origin. Here we add flags to indicate
that those fields need to be cleared on resubmission to siblings.
Bug 6064

This is a holdover from when the fed job_info list was added.
The cluster lock has to be cleared from both the job_ptr and
the job_info.
Bug 6064

Blessed by Tim.

Bug 6513

Regression from 70b4e06d.

Bug 6892.

Bug 6895.

Bug 6895

Bug 6895

Otherwise, we could send communication packets bigger than max_allowed_packet.

Bug 6832.

Co-authored-by: Tim Wickberg <tim@schedmd.com>

Regression introduced in 8d643e79.

Bug 6832.

The problem was freeing an interior pointer to buffer contents before
the call to FREE_NULL_BUFFER. The issue was only triggered when loading
an archived data with protocol version < 17.11.

Regression introduced in 8d643e79.

Bug 6832.

when not the head job.

Bug 6837

For more in depth explanation see comment 24

When specifying -j and not -s then non-eligible jobs will be shown
by sacct.
Time windows can also be used with -S and -E.
If --state is also used then non-eligible jobs won't be shown,
because non-eligible are not actually PD.

Bug 6873

# Conflicts:
#	NEWS

Bug 6805

Bug 6898

Cancelled jobs before start have time_start=0 in the DB, but their
time_end!=0 (the cancel time).
Query fixed to handle properly these cases for -s PD.

Bug 6894

Brought the option in line with the "numtasks" option you use when
not specifying --step. Preserved backwards compatbility for "numtask"
for steps. Also upated docs and expect test.

Bug 6861

Properly initialize structures throughout Slurm.

Bug 6613

Bug 6613

Bug 6613

Regression from aca37654

.

Bug 6826.

Co-authored-by: Chad Vizino <chad@schedmd.com>

These are conditions that need to remain constant until something
changes on the job to reevaluate.

Bug 6625

What was happening here is you had to not be >= operator to have the old
limits removed.  This makes it so it always happens.

Bug 6625

Bug 6625

Before we went up the tree to the next assoc_ptr.  As we validate an
association on the id as well as the uid the assoc_ptr was eventually
going to become invalid.  Setting it to NULL here solves a bunch of
issues with things later on.

Bug 6625

Bug 6625

Bug 6625.

Don't abort when the job doesn't have an association that was removed before the job was able to make it to the database.

Bug 6625

Bug 6625

The backfill scheduler keeps a local list of job pointers. Since the
backfill scheduler yields locks, it's possible for pending jobs to be
canceled and purged in these yield periods. The backfill scheduler then
has pointers to now invalid memory, and dereferencing those pointers is
undefined behavior and may result in a segfault.

This commit prevents purging jobs while the backfill scheduler is
running.

Bug 6621

Bug 6739

Bug 6785.

Bug 6608.

Bug 6807.

==8640== Thread 5 bckfl:
==8640== Syscall param openat(filename) points to unaddressable byte(s)
==8640==    at 0x4A81D0E: open (open64.c:48)
==8640==    by 0x5934ABB: _update_job_env (burst_buffer_cray.c:3338)
==8640==    by 0x5934ABB: bb_p_job_begin (burst_buffer_cray.c:3962)
...
==8640==  Address 0x6b96120 is 16 bytes inside a block of size 61 free'd
==8640==    at 0x48369AB: free (vg_replace_malloc.c:530)
==8640==    by 0x49D4873: slurm_xfree (xmalloc.c:244)
==8640==    by 0x490C317: free_command_argv (run_command.c:249)
==8640==    by 0x5934A5C: bb_p_job_begin (burst_buffer_cray.c:3947)
...
==8640==  Block was alloc'd at
==8640==    at 0x4837B65: calloc (vg_replace_malloc.c:752)
==8640==    by 0x49D4566: slurm_xmalloc (xmalloc.c:87)
==8640==    by 0x49D4B67: makespace (xstring.c:103)
==8640==    by 0x49D4C91: _xstrcat (xstring.c:134)
==8640==    by 0x49D4ECF: _xstrfmtcat (xstring.c:280)
==8640==    by 0x593497C: bb_p_job_begin (burst_buffer_cray.c:3936)
...

Bug 6807.

Bug 6807.