Skip to content
GitLab
  1. 20 Aug, 2018 1 commit
    • Michael Hinton's avatar
      Do not truncate MySQL database name at 33 characters. · 15c19c03
      Michael Hinton authored 
      MySQL permits up to 64-character database names, but Slurm was truncating
at 33-characters. If we exceed this limit, let the mysql_query fail and
give the admin a chance to sort it out, rather than truncating and then
failing to query against the un-truncated name later on.

While here correct the fatal() message.

Bug 5586.
      15c19c03
  3. 18 Aug, 2018 1 commit
  5. 16 Aug, 2018 5 commits
  7. 15 Aug, 2018 2 commits
  9. 14 Aug, 2018 3 commits
  11. 13 Aug, 2018 3 commits
  13. 11 Aug, 2018 5 commits
  15. 10 Aug, 2018 1 commit
  17. 09 Aug, 2018 2 commits
  19. 07 Aug, 2018 3 commits
  21. 06 Aug, 2018 1 commit
    • Tim Wickberg's avatar
      Modify slurm_send_only_node_msg() to catch issues with socket. · 06582da8
      Tim Wickberg authored 
      There are subtle issues involved in treating a TCP transmission
as a unidirectional message delivery layer.

The original code path looks like: connect(), write(), close().
But Linux handles the write() and close() asynchronously behind the
scenes, and does not block until that write() has been ACK'd by the
remote end. So the write() and close() may succeed, even with data
still in flight. A communication error - and message loss - would
have been silently ignored, leading to unreliable message transmission.

Worse yet, one side of the connection would believe it sent the message,
while the receive side swears it never saw the packets. This leads to
infrequent and yet seemingly impossible data loss, and a very tough
bug to chase down.

This teardown code tries to force the connection to shut down in an
orderly manner, giving Slurm a chance to catch a connection problem
and the upstream calling path an opportunity to retransmit.

This teardown code is based on an approach described in Section 7.5
of "UNIX Network Programming" Volume 1 (Third Edition), specifically
the subsection regarding SO_LINGER. (And also covers why SO_LINGER is
not sufficent to prevent this issue.)

Bug 5164.
      06582da8
  23. 04 Aug, 2018 1 commit
  25. 31 Jul, 2018 1 commit
  27. 27 Jul, 2018 2 commits
  29. 19 Jul, 2018 4 commits
  31. 18 Jul, 2018 3 commits
  33. 17 Jul, 2018 2 commits