Use unpackstr_xmalloc_chooser as part of safe_unpackstr_xmalloc macro.
This ensures that the slurmdbd is always working on escaped strings.

Fixes CVE-2018-7033.

Bug 4792.

Bug 4933

Bug 4888

introduced in commit ea85d123

Bug 4613

Fix job array dependency with "aftercorr" option and some task arrays in
    the first job fail. This fix lets all task array elements that can run
    proceed rather than stopping all subsequent task array elements.
Bug 4590

node_feature/knl_cray - Fix memory leak that can occur during normal
    operation. This will happen when an update request for a specific
    node happens.

If CnselectPath and/or SyscfgPath defined in knl_cray.conf file and
  slurmctld reconfigured, the original values of those paraemters
  would be over-written and their memory leaked.

Avoid setting node in COMPLETING state indefinitely if the job initiating
the node reboot is cancelled while the reboot in in progress. Bug
introduced in commit 7d246784

Bug 4536

increment ids for the tres_table.

Bug 4553

Turns out auto_increment=# doesn't work in MySQL at the time of writing
but does work correctly in MariaDB >=10.2.4+

See bug for more information.

This reverts commit 12794fb0.

increment ids for the tres_table.

Bug 4553

Turns out auto_increment=# doesn't work in MySQL at the time of writing
but does work correctly in MariaDB >=10.2.4+

See bug for more information.

This adds support for the --bb option "access_mode" in addition to
  "access" for better compatability with Cray's DataWarp options.
Related to bug 4528

In 1.10+ they changed the hid_t from an int to a long int which
messes things up as they use the top 32 bits for stuff right off
the bat.  This fixes the scenario by handing the number with a int32_t
instead of an int.

Bug 3795

Since NO_VAL = SLURM_BATCH_SCRIPT, the else statement would only compare
the job_id and not the step_id, thus when a batch step was removed all
the steps from that job would be removed too. Then when attempting to
remove the extern step in the next iteration, it was already removed
and we were incorrectly erroring out.

Bug 4458.

Fix memory leak of MailDomain configuration string when slurmctld daemon
   is reconfigured.
bug 4272 (comment 35)

slurm_load_job() prior to 17.11 returns the error code in errno and not
in rc.  With the addition of 47175901 if a job is removed from memory
before sbatch checks for the job again, sbatch could get in an loop
checking for the job. This only happens if you have a very small
MinJobAge (<10) -- which is not recommended.

Bug 4323

Bug 4306.

to start.

Bug 4434

This now matches the sinfo documentation.

Bug 4306.

Issue could be triggered when updating a partition node(s) with node(s)
that were already in the partition, incorrectly increasing the
node_record->part_cnt (number of associated partitions) and thus
incorrectly extending the array of pointers to partitions associated
with this node, leading to an array with repeated associated
partitions pointers.

Bug 4318.

On CLE 6.0 mungedir is /usr; a 'module unload' call then removes /usr/bin
from PATH which is rather inconvenient.

Bug 4334.

Memory TRES was getting the pn_min_memroy value when updating the job.
But the TRES memory value is the total memory of the job
(e.g pn_min_memory * cpus || pn_min_memory * nodes).

Bug 4177

CVE-2017-15566.

Bug 4228.

Starting in MariaDB 10.2 many of the api commands started
setting errno erroneously.

Backport of 5b934425

This reverts commit 7e5d3d15.

Turns out the spank_task_privileged needs to execute inside the child
process instead of the slurmstepd.

Bug 4298

If configured with NodeFeatures=knl_cray and there are non-KNL
nodes which include no features the slurmctld will abort without
this patch when attempting strtok_r(NULL).

bug 4294

Bug 4279

Before it would allow all sorts of things like
adding/subtracting/multiplying/etc.  It would cause warnings such as

/home/bart/slurm-tmp5/src/common/layouts_mgr.c: In function ‘_layouts_load_automerge’:
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:363:21: error: ‘*’ in boolean context, suggest ‘&&’ instead [-Werror=int-in-bool-context]
   *lvalue = *lvalue * *rvalue;     \
             ~~~~~~~~^~~~
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:1034:4: note: in expansion of macro ‘_entity_update_kv_helper’
    _entity_update_kv_helper(type_t, operator); \
    ^~~~~~~~~~~~~~~~~~~~~~~~
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:1086:4: note: in expansion of macro ‘_layouts_load_merge’
    _layouts_load_merge(bool, s_p_get_boolean);
[tag] [reply] [−] Private Comment 16

Bug 4062

Setting -Werror tricks the test into failing on the

"error: In the GNU C Library, "major" is defined by <sys/sysmacros.h>.
 For historical compatibility, it is  currently defined by <sys/types.h>
 as well, but we plan to remove this soon. To use "major", include
 <sys/sysmacros.h> directly. If you did not intend to use a system-defined
 macro "major", you should undefine it after including <sys/types.h>."

error. Since the normal Slurm build uses -Werror, this warning on including
both headers will then cause the build itself to fail.

Bug 3982.

Bug 4246

Bug 4246

Bug 4246

when a job spans a reservation that was modified (multiple records for
the same reservation).

Bug 4246

Bug 4246

Down waking nodes right after ResumeTimeout has been reached if they are
not responding. Otherwise we have to wait for ping_nodes() to handle
this work, thus SlurmdTimeout comes into play giving the sensation to
the end user that nodes got stuck in ALLOCATED# and job in CF state
until ping_nodes() decides to mark them DOWN and requeue the job.

Bug 4182

Update to commit 859f6c82