Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • ClimProjDiags ClimProjDiags
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • ClimProjDiagsClimProjDiags
  • Merge requests
  • !16

New version SU including tests

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Nuria Pérez-Zanón requested to merge develop-SU into develop-BioIndicators Dec 15, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 4

Hi @cchou,

To avoid overlapping on branch develop-BioIndicators, I have created 'develop-SU'.

Once you have check this content, I will be able to merge it to the branch develop-BioIndicators (not to the master yet).

As we have discussed:

  • SU uses parameters 'data' and 'theshold'
  • It includes some checks for you to follow in next developments
  • There are tests also in test/testthat/test-SU.R
  • I have tried to update the vignette if is not correct yet.

Could you have look at these changes and update the vignette if possible? If you wish, we can talk tomorrow again about this development and next steps.

hint: on the top of this page there are useful tools to see what is new here (see tab 'Changes')

Cheers,

Núria

Edited Dec 15, 2020 by Nuria Pérez-Zanón
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-SU