Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • N nes
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • Earth SciencesEarth Sciences
  • nes
  • Merge requests
  • !95

Fix create_spatial_bounds after sel

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged aho requested to merge develop-68-sel-create-bounds into master Feb 07, 2024
  • Overview 3
  • Commits 8
  • Pipelines 6
  • Changes 6

Hi @ctena

As we discussed, for issue #68, a bug in creating lat_bnds and lon_bnds. The attribute used for indices should be write_axis_limits instead of read_axis_limits.

I added the test for this fix in "2.3-test_bounds.py" since I regard it belongs to that category. Let me know if it is better to separate it as a new test file. I copied the style from the previous tests, and also added one check. If the lon_bnds doesn't match the expectation, the test fails.

# Check lon_bnds
if nessy_7.lon_bnds['data'].shape != (52, 2):
    raise Exception("Wrong lat_bnds.")

I ran all the tests on nord3v2 and all of them passed. Can you check the changes and let me know if anything can be improved? Thanks!

Best,
An-Chi

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-68-sel-create-bounds