User review: Ano_CrossValid
Hi @swild
Thanks for reviewing the function Ano_CrossValid() for us.
The function is in the branch develop-EOF here. Here are some recommended steps to test it.
- Read the documentation (i.e., the header of the function) to check if there is anything unclear or wrong.
- Find suitable data to test with both s2dverification::Ano_CrossValid and s2dv::Ano_CrossValid.
- One way to test the two functions together without confusion is to assign them with different names first. For example,
Ano_CrossValid_old <- s2dverification::Ano_CrossValid
source('<path_to_new_function>/Ano_CrossValid.R')
ano_CrossValid_new <- Ano_CrossValid
res_old <- Ano_CrossValid_old(exp, obs)
res_new <- Ano_CrossValid_new(exp, obs)
- Check if the two results are identical. The dimension order may change after the calculation, and you can use
s2dv::Reorder
to adjust the order back. - Besides the data itself, is there anything to be improved? E.g., the input parameters, the output format, etc.
One thing worth being noticed is that the per-paired method is used in the function. Please check if the function deals with NA values properly.
The review is not urgent, but it would be great to finish within two to three weeks. Please let me know if you have any questions, thanks again for your help!
Cheers,
An-Chi