User review: EOF
Hi @rmarcos
Thanks for reviewing the function EOF() for us.
The function is in the branch develop-EOF here. Here are some recommended steps to test it.
- Read the documentation (i.e., the header of the function) to check if there is anything unclear or wrong.
- Find suitable data to test with both s2dverification::EOF and s2dv::EOF.
- One way to test the two functions together without confusion is to assign them with different names first. For example,
EOF_old <- s2dverification::EOF
source('<path_to_new_function>/EOF.R')
EOF_new <- EOF
res_old <- EOF_old(...)
res_new <- EOF_new(...)
- Check if the two results are identical. The dimension order may change after the calculation, and you can use
s2dv::Reorder
to adjust the order back. - Besides the data itself, is there anything to be improved? E.g., the input parameters, the output format, etc.
The review is not urgent, but it would be great to finish within three to four weeks. Please let me know if you have any questions, thanks again for your help!
Cheers,
An-Chi