User review: Cluster
Hello @amartine
Thanks for reviewing function Cluster() for us.
The function is in the branch develop-Cluster here. Here are some recommended steps to test it.
- Read the documentation (i.e., the header of the function) to check if there is anything unclear or wrong.
- Find suitable data to test with both s2dverification::Cluster and s2dv::Cluster.
- One way to test the two functions together without confusion is to assign them with different names first. For example,
Cluster_old <- s2dverification::Cluster
source('<path_to_new_function>/Cluster.R')
Cluster_new <- Cluster
res_old <- Cluster_old(...)
res_new <- Cluster_new(...)
- Check if the two results. Notice that Cluster() generates random results (i.e., the outcome changes every time you run Cluster()), so you only need to examine the dimensions and if the numbers make sense. The dimension order may change after the calculation, and you can use
s2dv::Reorder
to adjust the order back. - Besides the data itself, is there anything to be improved? E.g., the input parameters, the output format, etc.
The review is not urgent, but it would be great to finish within two weeks. Please let me know if you have any questions, thanks again for your help!
Cheers,
An-Chi