Skip to content
GitLab
Closed
Issue created by aho@ahoMaintainer

User review: ProjectField

Hi @rfernand

Thanks for reviewing the function ProjectField() for us.

The function is in the branch develop-EOF here. You'll also need to load EOF.R to generate the input for ProjectField(). Here are some recommended steps to test it.

  1. Read the documentation (i.e., the header of the function) to check if there is anything unclear or wrong.
  2. Find suitable data to test with both s2dverification::ProjectField and s2dv::ProjectField.
  3. One way to test the two functions together without confusion is to assign them with different names first. For example,
ProjectField_old <- s2dverification::ProjectField
source('<path_to_new_function>/ProjectField.R')
ProjectField_new <- ProjectField

res_old <- ProjectField_old(...)
res_new <- ProjectField_new(...)
  1. Check if the two results are identical. The dimension order may change after the calculation, and you can use s2dv::Reorder to adjust the order back.
  2. Besides the data itself, is there anything to be improved? E.g., the input parameters, the output format, etc.

It would be great if you can document the review here, but there is no need to be exhaustive. The review is not urgent, but it would be great to finish around two weeks. Please let me know if you have any questions, thanks again for your help!

Cheers,
An-Chi