User review: Spread
Hi @amartine
Thanks for reviewing Spread() for us. The function is in the branch develop-Spread. Here are some recommended steps to test it.
- Read the documentation (i.e., the header of the function) to check if there is anything unclear or wrong.
- Find suitable data to test the function.
- Some packages may need to be loaded manually beforehand, e.g.,
library(multiApply)
. Besides, some other functions in s2dv may be used in the testing functions too, solibrary(s2dv)
can be added to the script. - One way to test the s2dverification and s2dv functions together without confusion is to assign them with different names first. For example,
library(s2dv)
library(multiApply)
Spread_old <- s2dverification::Spread
source('<path_to_new_function>/Spread.R')
Spread_new <- Spread
res_old <- Spread_old(...)
res_new <- Spread_new(...)
Of course, if you want to test them on two separate consoles, it is also fine.
- Check if the two results are consistent. The dimension order may change after the calculation, and you can use
s2dv::Reorder
to adjust the order back. - Besides the data itself, is there anything to be improved? E.g., the input parameters, the output format, etc.
It will be great if the review can be done within two weeks, but don't hesitate to let me know if you have any problems or questions!
Thanks,
An-Chi