Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • s2dv s2dv
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • s2dvs2dv
  • Merge requests
  • !189

CRPS() and CRPSS(): Add parameter na.rm

  • Review changes

  • Download
  • Patches
  • Plain diff
Open vagudets requested to merge dev-crpss into master Aug 19, 2024
  • Overview 4
  • Commits 6
  • Pipelines 2
  • Changes 8

Hi @cdelgado and @ptrascas,

I found this branch dev-crpss with the following changes:

  1. Adding the 'na.rm' parameter to CRPS and CRPSS, by @cdelgado
  2. Fixing a bug in the computation of the mean of the observations in .CRPS() and .CRPSS(), by @ptrascas

I have reviewed the changes, added unit tests, made some adjustments and fixed the pipeline. If you agree, I can merge these changes to the master branch so that they will be included in the next release (which should be soon).

Let me know if you have any issues with this. Also in the future please remember to open a merge request for the changes! 👼🏽

Thanks,

Victòria

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dev-crpss