Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • s2dv s2dv
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • s2dvs2dv
  • Merge requests
  • !197

fix RandomWalk error when A_better or B_better is NA

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Carlos Delgado Torres requested to merge develop-RandomWalk-fix-NA into master Nov 18, 2024
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

Hi @vagudets, @abatalla, @tkariyat,

I have just fixed a small bug in .RandomWalkTest when A_better or N.eff is NA (e.g. in the case that the time series are all NAs).

Error in if (!is.na(output$score) & N.eff >= A_better) { : 
  missing value where TRUE/FALSE needed

Basically, I have replaced N.eff >= A_better with isTRUE(N.eff >= A_better). Then, the error does not arise, and the significance is returned as NA. This is the commit: 4fb8076f

Could you please review and merge when you have time?

Thank you!
Carlos

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-RandomWalk-fix-NA