Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • s2dv s2dv
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 17
    • Issues 17
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • s2dvs2dv
  • Merge requests
  • !74

Develop unittest fixes

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged aho requested to merge develop-unittest_fixes into master Jun 17, 2021
  • Overview 2
  • Commits 9
  • Pipelines 2
  • Changes 13

Hi @nperez

Due to the unknown failure of the pipeline, I found that the unit tests were not run on the GitLab pipeline because ^tests$ was added in .Rbuildignore. Therefore, - R -e 'covr::package_coverage()' in the .gitlab-ci.yml couldn't work because there was no unit test. I tried to remove ^tests$ from .Rbuildignore, but the pipeline failed to run testthat.R for unknown reasons. I don't know why but the same setting works in startR. So now, ^tests$ is still in .Rbuildignore, and we need to run the unit tests on our own everytime after the development.

The branch includes the fixes for the errors shown in unit tests (but I didn't realize since the tests were not run all the time.) Since it's too late for the new release, we have to wait for the next time. Sorry for the trouble.

An-Chi

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-unittest_fixes