Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • S s2dverification
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 65
    • Issues 65
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • s2dverification
  • Merge requests
  • !197

WIP: Season uses Apply and n-dimensional arrays with named dimensions

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Nuria Pérez-Zanón requested to merge devel-SeasonApply into master Jul 18, 2019
  • Overview 4
  • Commits 5
  • Pipelines 0
  • Changes 7

Hi @aho,

I have converted Season function to work with n-dimensional arrays with named dimension by using Apply.

I have also converted the documentation to roxygen2 format. This implies that after generating the documentation using devtools::document(), the NAMESPACE should be corrected including all the functions that haven't the roxygen2 format (copy and paste the old NAMESPACE file version)

The merge request is WIP, until we decide when this n-dimensional arrays with named dimension should be used in all the s2dverification functions. We can consider reviewing the branch develop-multiApply.

Furhter discussions to take into account are: the name of the parameters: 'var' or 'data' (as in ClimProjDiags and Start output), 'posdim' default for 'time'.

I have included a lot of tests. Maybe you want to see them for your own developments.

Cheers,

Núria

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: devel-SeasonApply