Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • startR startR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 29
    • Issues 29
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • startRstartR
  • Merge requests
  • !119

Develop time attr month unit

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged aho requested to merge develop-time_attr_month_unit into master Jan 27, 2021
  • Overview 4
  • Commits 3
  • Pipelines 0
  • Changes 2

Hi @nperez

This is the fix for the second problem in issue #86 (closed). The problem lied in the conversion of time metadata from numeric value to date if the unit is 'month'. The code didn't consider different types of the calendar before.

I ran the unit tests of the calendar issue and they worked fine. I don't have all the possible cases regarding the combination of different calendars and units(*), so I can't guarantee the calendar issue is completely solved.

We can either merge this fix now and wait for potential errors to happen (if there is any) in the future, or ask if Marga can provide us different data to do the test.

(*) calendar: gregorian/360_day/365_day
unit: sec/hour/day/week/month
unit with or without 'since'

Cheers,
An-Chi

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-time_attr_month_unit