Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • startR startR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • startRstartR
  • Merge requests
  • !126

Remove incorrect check of character selector.

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged aho requested to merge develop-remove_wrong_selector_check into master Feb 25, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Hi @nperez

This is a fix for issue #91 (closed). There was a character selector check having problems. In fact, it was a development I made for issue #7 (closed) and it was wrong. It tried to examine if all the files have the selector when its type is character, for example, region = 'Nino3; but it doesn't serve this purpose and causes error in issue 91.

I simply removed that check. I'm still not sure if Start() returns any error or warning when some file doesn't have the assigned character selector because I have no suitable files to test. For class 'numeric' and 'POSIXct', Start() shows a warning if the value is not exactly the same (we've learned it from lat/lon and time selector issues). I hope it does something to the character case too.

If you agree, we can merge it (and see if we need to create a new minor version depending on Aude's need.)

Ps., All the unit tests pass. I tested them in WS.

Best,
An-Chi

Edited Feb 25, 2021 by aho
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-remove_wrong_selector_check