Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • startR startR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 29
    • Issues 29
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • startRstartR
  • Merge requests
  • !35

Fix in Start() to work with sub_array_indices

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Nuria Pérez-Zanón requested to merge develop-Startindices into master Nov 05, 2019
  • Overview 6
  • Commits 10
  • Pipelines 0
  • Changes 4

Hi @aho,

This merge request fixes issue #38 (closed).

I think you should review it, so, you can keep track of all the modifications undertaken in the package.

On the other hand, do you have any way to automatically tests that check the modifications done in the code to not break the function? I think you should prepare automatic tests for startR as you already did for some functions in s2dverification using testthat. In this case, you can use the examples from "use cases" documentation as starting point.

Thanks,

Núria

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-Startindices