Bug: Wrong name for fcst time dimensions in load.R

This is minor but I'm opening an issue to keep track of it so that I won't forget by the time you're back.

In load.R the name added to the fcst date dimension after the Start() call is 'fcst_year' instead of 'fcst_syear'. This is inconsistent with the time_dims vector defined in the startR_to_s2dv() fun. It's not causing problems now because we are only asking for one year, so it coincidentally bypasses the check in s2dv_cube() (since 1x3 is the same as just 3). However it would fail if the dim size were greater than 1, i.e. if we had more than one forecast year.

I'll change it in dev-loading-seasonal, which is now up to date with master, and when you come back we can discuss if needed and then merge the correction.

Cheers,

Victòria

Edited Apr 07, 2022 by vagudets