Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • SUNSET SUNSET
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 43
    • Issues 43
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • SUNSETSUNSET
  • Merge requests
  • !152

Draft: Dev cross cleanup s2dv functions

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed abatalla requested to merge dev_cross-cleanup_s2dv_functions into master Aug 12, 2024
  • Overview 1
  • Commits 55
  • Pipelines 1
  • Changes 67

Hi @vagudets,

The dev_cross-cleanup_s2dv_functions branch was created from the dev_cross branch. I have deleted the functions that are identical to their version in the s2dv master branch, as detailed in #132 (closed).

Regarding the functions that have different versions in the SUNSET dev_cross branch and the s2dv master branch:

  • Bias(), Corr() and SprErr() seem to be ahead in the s2dv master branch, with no conflicting developments in the SUNSET dev_cross branch. I believe that NAO() is also ahead in the s2dv master branch, but I am not 100% sure (see #140 (closed)).

  • RPS() and RPSS() are ahead in the SUNSET dev_cross branch with no apparent conficting developments in the s2dv master branch.

Maybe we can just keep RPS() and RPSS() in this branch and delete the other functions?

Also, the pipeline fails due to the latest commit in dev_cross (add fix aggregation d87721aa). I will leave it as is for now.

Cheers,

Ariadna

Edited Aug 12, 2024 by abatalla
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dev_cross-cleanup_s2dv_functions