Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • SUNSET SUNSET
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 43
    • Issues 43
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • SUNSETSUNSET
  • Merge requests
  • !189

Bugfix: Save forecast category probabilities in the correct order

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged vagudets requested to merge dev-bugfix_save_probabilities_in_order into dev_cross Feb 05, 2025
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Hi @nperez and @ptrascas,

Just as Núria mentioned yesterday offline, the probabilities were not being saved correctly. What happened was the arrays for each category were being appended at the beginning of the list:

# before
        probs_fcst <- append(list(Subset(fcst_probs[[ps]],
                                         along = 'bin',
                                         indices = perc,
                                         drop = 'selected')).
                             probs_fcst)

instead of at the end:

# now
        probs_fcst <- append(probs_fcst,
                             list(Subset(fcst_probs[[ps]],
                                         along = 'bin',
                                         indices = perc,
                                         drop = 'selected')))

Then the names were defined in the opposite way, so the category names did not correspond to the data.

This is fixed now, and I verified the consistency opening the files with NcToArray(). I also checked that the percentiles file is consistent (e.g. p10 < p33 < p67 < p90).

This can be merged whenever you consider.

Cheers,

Victòria

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dev-bugfix_save_probabilities_in_order