Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • CSTools CSTools
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • External
  • CSToolsCSTools
  • Issues
  • #120
Closed
Open
Issue created Mar 31, 2023 by Carlos Delgado Torres@cdelgadoDeveloper

Bug in Calibration when having a grid point with no observations

Hi @erifarov and @aho,

I am getting an error with the new CSTools::Calibration version when there are NAs for all time steps in some grid points (for example, when using ERA5land that only provides data over land).

I think it is because how the function .data.set.sufficiently.large() is used with dat_dim, but I'm not totally sure. I say it because, before having dat_dim, the uncorrected exp or NA (depending on na.fill) were directly returned without going througth the rest of .cal. But the whole function is now run even if all obs are NAs.

I could fix it by replacing "complete.obs" with "na.or.complete" in cor.obs.fc <- cor(fc.ens.av, obs, use = "complete.obs") (lines 796 and 817), but I don't know if it can affect other cases.

Could you please have a look?

Thanks a lot,
Carlos

Assignee
Assign to
Time tracking