Expanding list of accepted temporal dimensions in s2dv_cube()
Hi @nperez
As we discussed a while ago, for the Auto-S2S tool we need to use the s2dv_cube()
fun to convert the output of Start() to an object of class s2dv_cube
. One of the problems we have now is that the function currently only recognizes 'sdate'
, 'time'
and 'ftime'
as temporal dimension names (lines 98 and 164), and our objects have different time dims (e.g. 'sweek'
, 'sday'
, 'syear'
).
Therefore, we need to modify s2dv_cube()
so we can use it in the tool. That's why I'm opening this issue.
I see two possible options:
- Simply hardcoding the new dimension names that we need, adding them to the current list of accepted names.
- Add new input parameter allowing users to add additional time dimension names. I think this would make the function more flexible and easily accomodate similar problems in the future, but there might be some reasons not to follow this approach I'm not aware of.
If you're okay with this I will create a new branch to start working on this enhancement.