Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • CSTools CSTools
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • External
  • CSToolsCSTools
  • Merge requests
  • !120

Develop MostLikelyTercile_vignette

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Eva Rifà requested to merge develop-MostLikelyTercile_vignette into master Sep 13, 2022
  • Overview 0
  • Commits 3
  • Pipelines 1
  • Changes 1

Correct the following errors from [MostLikelyTercile_vignette.Rmd]:(https://earth.bsc.es/gitlab/external/cstools/-/blob/develop-MostLikelyTercile_vignette/vignettes/MostLikelyTercile_vignette.Rmd)

  1. Error in the variable names ano_exp$data and ano_obs$data. The correct names were Ano_Exp$data and Ano_Obs$data.
  2. List indexing was wrong in these lines:
mask_rpss <- RPSS[[1]]
mask_rpss[RPSS[[1]] <= 0] <- 1
mask_rpss[is.na(RPSS[[1]])] <- 1
mask_rpss[RPSS[[1]] > 0] <- 0

"From the RPSS, we create a mask: regions with RPSS <= 0 will be masked.", only RPSS (i.e., RPSS$data$skillscore) is used. More consistent with the explanation to use RPSS$data$skillscore to create mask_rpss (and in PlotMostLikelyQuantileMap(), use mask = mask_rpss[, , 1])

# Suggest using RPSS$data$skillscore to create mask_rpss
mask_rpss <- ifelse((RPSS$data$skillscore <= 0) | is.na(RPSS$data$skillscore), 1, 0)
  1. Figures from PlotMostLikelyQuantileMap() function returned the following error: Error in plot.new() : figure margins too large. It has been increased the file height and width and reduced the legend scale in this commmit.

  2. Remove library(s2dverification) and library(multiApply) since they're not necessary for this vignette; add library(ClimProjDiags) for Subset()

  3. Change to use s2dv::ProbBins (right now, it uses the one from s2dverification)

PB <- ProbBins(Ano_Exp$data, fcyr = numyears, thr = c(1/3, 2/3), quantile = TRUE,
               posdates = 3, posdim = 2, compPeriod = "Without fcyr")
Edited Sep 13, 2022 by Eva Rifà
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-MostLikelyTercile_vignette