Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • CSTools CSTools
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • External
  • CSToolsCSTools
  • Merge requests
  • !166

Improve CST_SaveExp warnings, filenames and Dates dimension acceptance

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Eva Rifà requested to merge develop-CST_SaveExp_sdates.nc into master Apr 14, 2023
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 2

Due to the usage within the Climate Services Verification Suite there was the need of some improvements:

  • When the filename is taken from Dates, the format has been corrected to: <var_name>_YYYYmmdd.nc. Before, if the Dates had time values included, they were included in the filename, which was not correct.

  • If Dates array has more dimensions additionally to sdate_dim and ftime_dim but they are of length 1, they are dropped.

  • Some Warnings are also improved:

    • "Parameter 'startdates' should be a character string containing the start dates in the format 'yyyy-mm-dd', 'yyyymmdd', 'yyyymm', 'POSIXct' or 'Dates' class." to "Parameter 'startdates' should be a character string containing the start dates in the format 'yyyy-mm-dd', 'yyyymmdd', 'yyyymm', 'POSIXct' or 'Dates' class. Files will be named with Dates instead.". and
    • "Spatial coordinate names do not match any of the names accepted by the package." to "Spatial coordinates not found.".
    • The warning: Detected unknown dimension: region, sday, sweek has been removed.

@nperez Could you run your code with this development? You can source the function here: https://earth.bsc.es/gitlab/external/cstools/-/raw/develop-CST_SaveExp_sdates.nc/R/CST_SaveExp.R

Thanks!

Edited Apr 14, 2023 by Eva Rifà
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-CST_SaveExp_sdates.nc