Convert job_scheduler.c over to slurm_thread_create.

While here fix two function signatures, as the only error
path was if pthread_create failed, and the calling locations
ignored the return code anyways.