Bug fixes in powercapping logic
Changed spaces to tabs at start of lines. Minor changes to some formatting. Added the new files to the RPM (slurm.spec file). Prevent memory leak of "l_name" variable if which_power_layout() function is called more than once. Initialize "cpufreq" variable in powercap_get_cpufreq() function. Array "tmp_max_watts_dvfs" could be NULL and used if "max_watts_dvfs" variable is NULL in powercap_get_node_bitmap_maxwatts_dvfs() Variable "tmp_pcap_cpu_freq" could be used with uninitialized value in function _get_req_features() Variable "tmp_max_watts" could be used with uninitialized value in function _get_req_features() Array "tmp_max_watts_dvfs" could be used with uninitialized value in function _get_req_features() Array "allowed_freqs" could be NULL and used if "node_record_count" variable is zero in powercap_get_job_nodes_numfreq() Overwriting a memory buffer header (especially with different data types) is just asking for something bad to happen. This code from function powercap_get_job_nodes_numfreq(): allowed_freqs = xmalloc(sizeof(int)*((int)num_freq+2)); allowed_freqs[-1] = (int) num_freq; Clean up memory on slurmctld shutdown
Please register or sign in to comment