The argument is redundant and possibly confusing for pack jobs

The value is redundant and possibly misleading for pack jobs

The information is redundant, and possibly inaccurate for
  heterogeneous jobs

Bug 4634

job container where if the step was canceled would also cancel the stepd
erroneously.

Bug 4634

one already exists owned by a different user will be logged and the job
held.

Bug 4614

Bug 4681

In preparation for release of v18.08.0-pre1 later this week.

from when last started.

Signed-off-by: Danny Auble <da@schedmd.com>

invalid reads.

Bug 4664

if LaunchParameter test_exec is set.

Bug 4439

rights by a secondary group id.

Bug 4439

before the primary takes control.

The primary will wait until the backup has replied with it all the way
done shutting down before it takes over.  Before it would just wait 2
seconds which probably was ok in most situations.  Now we don't return
until it is completely out.

This also ups the CONTROL_TIMEOUT from 10 -> 30 seconds.

Bug 4446

introduced in commit ea85d123

Bug 4613

Expand advanced reservation feature specification to support parenthesis and
    counts of nodes with specified features. Nodes with the feature currently
    active will be prefered.
bug 4604

Commit 818a09e8 introduced a new state JOB_OOM and a new state reason
FAIL_OOM (OutOfMemory). The problem was that it based the decision upon
the value of the different memory.[*].failcnt being > 0.

That lead to "false positives" situations when the usage hit the limit
but the Kernel was able to reclaim pages and the process managed to finish
successfully. When this happens there might not necessary be OOM_KILL
events happening.

This patch makes it so the JOB_OOM state is set based upon OOM_KILL events
detected instead of usage hitting the limit. The usage hit will still
be logged as an info() message, and further work will be needed in the
master branch to better discern both type of events, maybe changing
the API and getting rid of the current SIG_OOM and a potential new
SIG_OOM_KILL.

OOM_KILL event is detected using the eventfd notification mechanism
on the cgroup v1 control/event files:
https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt

If we plan to support cgroup v2, we should monitor 'memory.events' file
modified events. That would mean that any of the available entries changed
its value upon notification.
Entries include: low, high, max, oom, oom_kill:
https://www.kernel.org/doc/Documentation/cgroup-v2.txt
https://patchwork.kernel.org/patch/9737381
but since this is a fairly recent change many sites might be running
kernels still not supporting this feature.

Bug 3820.

Correct SLURM_NTASKS and SLURM_NPROCS environment variable for heterogeneous
    job step. Report values representing full allocation.

This reverts commit d3141dc9.

Bug 4655

Turns out there are many ways to get this information directly from
the slurmstepd.  As you can already get this information from ps we
decided to just revert back to the old non-authenticated way of doing
things.

If we do need this in the future we need to patch the stepd as well as
the slurmd here in all the RPC's that try to grab this.

A user could easily run scontrol (or their own home baked thing)
on the node which will give them a direct contact with the slurmstepd.

This reverts commit c4fb9bc3.

This reverts commit d3141dc9.

Bug 4655

Turns out there are many ways to get this information directly from
the slurmstepd.  As you can already get this information from ps we
decided to just revert back to the old non-authenticated way of doing
things.

If we do need this in the future we need to patch the stepd as well as
the slurmd here in all the RPC's that try to grab this.

A user could easily run scontrol (or their own home baked thing)
on the node which will give them a direct contact with the slurmstepd.

Bug 4656

bug 4607

Original source:
https://github.com/cfenoy/influxdb-slurm-monitoring

Bug 4619.

Report NodeFeatures plugin configuration with scontrol and sview commands.
bug 4036

switch count.

Bug 4381

Bug 4620

Bug 4620

find jobs that ran on specific nodes.

Bug 4602

This isn't a real problem, but older compilers will complain about it.
Newer compilers know in order to get into the place it could be used
'have_count' would have to be set.  If that is set then feature_list
would also be set.

itself.

Bug 4638

when using multi-prog option.

Bug 4621

Fix output file containing "%t" (task ID) for heterogeneous job step to
    be based upon global task ID rather than task ID for that component
    of the heterogeneous job step.

Fix for possible memory corruption in srun when running heterogeneous
job steps.
bug 4626

This partially reverts 89bcd975 and aac6bd39

Turns out you can't use a list_for_each and lock something inside the
list_for_each function that does a lock without the write lock.

Bug 4611