As well as jobcomp functions.

This also renames some to match the calls of other things.

Bug 4292

No other options use underscores, so make these consistent with
the rest. Both old and new syntax is supported for now.

Change all 'verbose' option output to use dashes, and adjust
the testsuite to match.

Fix a few related documentation errors while here.

If configured with NodeFeatures=knl_cray and there are non-KNL
  nodes which include no features the slurmctld will abort without
  this patch when attemping xstrdup(NULL).
bug 4294

Bug 4279

Before it would allow all sorts of things like
adding/subtracting/multiplying/etc.  It would cause warnings such as

/home/bart/slurm-tmp5/src/common/layouts_mgr.c: In function ‘_layouts_load_automerge’:
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:363:21: error: ‘*’ in boolean context, suggest ‘&&’ instead [-Werror=int-in-bool-context]
   *lvalue = *lvalue * *rvalue;     \
             ~~~~~~~~^~~~
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:1034:4: note: in expansion of macro ‘_entity_update_kv_helper’
    _entity_update_kv_helper(type_t, operator); \
    ^~~~~~~~~~~~~~~~~~~~~~~~
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:1086:4: note: in expansion of macro ‘_layouts_load_merge’
    _layouts_load_merge(bool, s_p_get_boolean);
[tag] [reply] [−] Private Comment 16

Bug 4062

Setting -Werror tricks the test into failing on the

"error: In the GNU C Library, "major" is defined by <sys/sysmacros.h>.
 For historical compatibility, it is  currently defined by <sys/types.h>
 as well, but we plan to remove this soon. To use "major", include
 <sys/sysmacros.h> directly. If you did not intend to use a system-defined
 macro "major", you should undefine it after including <sys/types.h>."

error. Since the normal Slurm build uses -Werror, this warning on including
both headers will then cause the build itself to fail.

Bug 3982.

Bug 4246

and display CPU if no TRES' are requested -- except for resveration
reports.

Bug 4246

Bug 4246

when a job spans a reservation that was modified (multiple records for
the same reservation).

Bug 4246

Bug 4246

Down waking nodes right after ResumeTimeout has been reached if they are
not responding. Otherwise we have to wait for ping_nodes() to handle
this work, thus SlurmdTimeout comes into play giving the sensation to
the end user that nodes got stuck in ALLOCATED# and job in CF state
until ping_nodes() decides to mark them DOWN and requeue the job.

Bug 4182

BLCR is deprecated, and will require both --with-blcr and
--enable-deprecated options to configure to enable.

Update to commit 859f6c82

E.g., gpu:tesla:2 would have parsed as quantity "telsa" of gpu.
Change the index value to the end of the array (-1 index value).

Bug 4250.

Rather than end up with "%.-1s" printed out in the output as snprintf
refused to parse the format specifier.

Bug 4164.

bugzilla #4238 - Added a hint for the window manager to all popups and windows
in order to get max, min, close buttons in Gnome, XFCE, and others.

Bug 4244

Pending job with administrator extended TimeLimit beyond partition's
MaxTime remains pending with reason PartitionTimeLimit
bug 4262

The contoller will return node records with a NULL name for nodes that
are hidden. This is so that you can map a partition_info's nodes --
using it's node_inx[] -- to a node record in the returned node_array
from slurm_load_node().

Previously the perl api would leave an undefined object in the the
node_array if the hidden nodes were found before a real node in the
node_array and any hidden nodes at the end of the array from the
controller wouldn't be counted for in the perl node_array. This patch
adds empty hashes for hidden nodes and preserves the record_count and
node_array from the slurmctld.

Bug 4250

The perl api leaves undefined objects in the node_array returned by
load_nodes() for any node that is hidden.

But 4250

Bug 4003

as process exits

Bug 4003

When creating a reservation, correct logic to ignoring job allocations on
    request.
bug 4172

When creating a reservations, validate the CoreCnt specification matches
    the number of nodes listed.
bug 4172

to prev commit 33e352a6

In a job allocation spanning KNL and non-KNL nodes and requiring a reboot,
    do not attempt to set default NUMA or MCDRAM modes on non-KNL nodes.
bug 4205

Bug 4252

Bug 4252

Base time limit upon the time that the latest job component is available
(after all nodes in all components booted and ready for use).

when using xstrcasecmp. Matching up with other xstrcmp() functions.

was missing