As found by CLANG

Bug 3764.

d31965f3 triggered it

When running sacct from a federated client, the db returns jobs for each
cluster with duplicate jobs removed on each cluster. A federated job
could have ran on a different cluster when the before the jobid's
rolled. This patch filters out past old federated jobs and leaves the
newest ones.

With sacct, if multiple clusters were selected then the jobs would be
grouped together by cluster with each cluster's job sorted by submit
time. This patch sorts all of the job by submit time if multiple
clusters are requested.

KNL features: Always keep active and available features in the same order:
    first site-specific features, next MCDRAM modes, last NUMA modes.
bugs 3614, 3679

This change will avoid possible problems in the event that "capmc get_mcdram_cfg"
  fails to return a mcdram_pct value. Never observed, but this will harden the
  code just in case...
bug 3679

accounting_storage/[mysql|slurmdbd].

Bug 3574

Get the federation information from the dbd instead of the controllers.

Bug 3741.

Field is not currently used, but fix it now after handling bug 3738.

Bug 3738.

energy values to uint64_t and storing them in TRES.  What was happening before
was the NO_VAL64 was being added to other NO_VAL64's and creating huge numbers.

when shutting down.

Fix regression introduced by commit 32ded0c3.

Bug 3438.

Bug 3438.

Bug 3438.

cpus on the node.

Bug 3714.

Bug 3714.

Match documented string.

Bug 3711.

sched/backfill: Fix bug related to advanced reservations and the need to
    reboot nodes to change KNL mode.
bug 3645

Bug 3616

bug 3680

bug 3689

bug 3680