Anything that is contigent on "if (!HAVE_MALLOC)" is a bad idea. Plus, these
aren't actually used by anything. Remove files and stop building them.

Always include "config.h".

Rearrange standard library includes while here, and clean up some additional
ifdef contamination missed on the first pass.

Cleanup the other directories in src/.

Remove WITH_PTHREAD from configure as well while here.

Require <pthread.h> and cleanup #ifdef blocks.

Sort system includes.

Remove local mutex_* macros. Require <pthread.h> and fixup includes.

Remove list_mutex_* macros. Require <pthread.h> and remove WITH_PTHREAD

Remove cbuf_mutex_* macros. Require <pthread.h> and remove WITH_PTHREAD

Replace all __CURRENT_FUNC__ references with c99 __func__

Remove NULL and bool definitions, use <stddef.h> and <stdbool.h> instead.

AF_SLURM => AF_INET; AF_INET is already commonly used.

SLURM_INADDR_ANY macro never used.

No functional change in theory. Cleanup headers to reduce the mostly-useless
for some time now.

1) Remove common/{getopt.[ch],getopt1.c} files and remove from build. Use
   C99-required functions from <unistd.h> and <getopt.h>.

2) <inttypes.h> is required by C99 and has been required for some time. Remove
   #ifdef blocks and replace some older <stdint.h> includes.

3) <pthread.h> isn't optional at this point. PTHREAD_MUTEX_INITIALIZER is
   required throughout.

4) Use <limits.h> instead of <values.h> or <float.h>

5) <string.h> is required by C99. Remove long-deprecated <strings.h> includes.

# Conflicts:
#	src/plugins/select/cray/select_cray.c
#	testsuite/expect/test1.84

    for better robustness.  This cray/select plugin code has
    been modified to remove a possible timing window where two
    aeld pthreads could exist, interfering with each other through
    the global aeld_running variable.

    An additional validity check has been added to the data provided
    to aeld through an alpsc_ev_set_application_info() call.
    If an error is returned from that call, only certain errors
    need the current socket connection closed to aeld and a new
    connection established.  Other error returns will log an
    error message and keep the current session established with
    aeld.

This might possibly be related to bug 2334, but it's a long shot.

slurm.conf instead of all.  If looking for specific addresses use
TopologyParam options No*InAddrAny.

This was broken in 15.08 with the advent of the referenced TopologyParams
the commits 9378f195 and c5312f52 are no longer needed.

Bug 2696

Thread names can only be 16 characters long, plus we already know that the threads are from the slurmctld.

at the same time.

Bug 2683

Turns out making a variable static in a function will make it not safe
when dealing with threads.

Used for development and testing purposes

burst_buffer/cray - Add support for rounding up the size of a buffer reqeust
    if the DataWarp configuration "equalize_fragments" is used. That option
    can significantly increase the size of a burst buffer allocation in order
    to create equal sized buffers on all server nodes for performance reasons.
    Support current only provided by Cray for job buffers, not persistent
    burst buffers.

If node_feature/knl_cray plugin is configured and a GresType of "hbm"
is not defined, then add it the the GRES tables. Without this, references
to a GRES of "hbm" (either by a user or Slurm's internal logic) will
generate error messages.
bug 2708

With slurm-15.08.10, we're seeing occasional segfaults in slurmstepd. The logs point to the following line: slurm-15.08.10/src/slurmd/slurmstepd/mgr.c:2612

On that line, _get_primary_group() is accessing the results of getpwnam_r():
    *gid = pwd0->pw_gid;

If getpwnam_r() cannot find a matching password record, it will set the result (pwd0) to NULL, but still return 0. When the pointer is accessed, it will cause a segfault.

Checking the result variable (pwd0) to determine success should fix the issue.