Coverity was complaining that the return value of s_p_get_* was
ignored. I added typecasting of the return value to (void) where
needed. No change in logic, just making Coverity happy ;)

This is an addition to commit cb7ed937

Related to commit 974878cd

The kmem limit was added in commit 084c9308

bug 3191

bug 3192

Continuation of commit 2fd4d7a6. MySQL dropped support for 'ignore',
unconditionally remove that to avoid issues with mismatching client + server
versions like in bug 3189.

Improve reported estimates of start and end times for pending jobs.
bug 3184

Cray: Prevent abort in backfill scheduling logic for requeued job that has
    been cancelled while NHC is running.
bug 3185

Old command line would not work with FreeBSD. New command line
  should work with all systems
bug 3021

Add mechanism to constrain kernel memory allocation using cgroups. New
    cgroup.conf parameters added: ConstrainKmemSpace, MaxKmemPercent, and
    MinKmemSpace.
bug 2917

Also replace string copies with setting of pointers for better
performance.

Modify DataWarb example to use an environment variable rather than absolute path

older versions.  This is fixed differently going forward, so we can
start warning about deprecated declarations again.

the way we use it and it also is deprecated, most likely since it
really isn't needed.

new glibc 2.24+ that depricates readdir_r.

Bug reported by Coverity

Add suppoprt for --mem_bind=prefer option to prefer, but not restrict memory
    use to the identified NUMA node.
bug 3126

Modify cpu_bind and mem_bind map and mask options to accept a repetition
    count to better support large task count. For example:
    "mask_mem:0x0f*2,0xf0*2" is equivalent to "mask_mem:0x0f,0x0f,0xf0,0xf0"
bug 3065

Remove include, this was merged into xstring.h with the
rest of the string functions.

This reverts commit 8bc8e7e6.

The slurm_strcasestr() which existed in v16.05 was removed in v17.02.

Found by Coverity