Coverity CID 45252

The string "buf" might not be terminated.
Coverity CID 167130, high impact.
Also fixed formatting to match Linux coding standard.

This will be especially valuable when generating reports for a
  federation of clusters that no longer reflects the current
  federation.

Earlier tests would generate errors in a federation as the reports
  would include information from non-local clusters

Bug 3566.

In 6eec8022, the cluster's recv connection is now being destroyed when
the cluster is being destroyed. The problem that showed itself was that
when a remote cluster is removed from the federation, the controller
calls slurmdb_destroy_federation_rec() which destroys the cluster's in
the list. Both the persistent recv thread and the cluster's recv are
pointing to the same thing so when the controller removed the recv
persistent connection the recv thread was pointing to bad memory.

end at the same time.

Bug 3604.

Modify sreport to report all jobs in federation by default. Also add --local
    option.

Modify sacct to accept "--cluster all" option (in addition to the old
    "--cluster -1", which is still accepted). This makes sacct behave
    more like the other commands.

Modify sacct to report all jobs in federation by default. Also add --local
    option.

This RPC is still needed for version 17.02 commands executed
  against version 17.11 slurmctld daemon

perl api.

This changed in 17.11 where if the size was 0 we would return 0 which messes
up the perl api.

Bug 3644

jobs have a priority that is lower than the selected job. Previous logic
would permit other jobs with equal priority (no jobs with higher priority).

Bug 3650

circumstances.

array element per line.

Bug 3573

If the depend_list is NULL or has zero elements, the string should
be cleared as well.

Bug 3651.

The field needs to have its own copy, otherwise the pointer will
become invalid when xfree()'d by a separate array task.

Bug 3665.

So that it is the same max length as in src/common/env.c.

Used for explicitly laying out tasks on large CPU count nodes (e.g., KNL).

Bug 3675.

For use in federated environments.