I have implemented the changes as you suggested:   using a "-dd" option to indicate that the display of the script is wanted, and setting both the "SHOW_DETAIL" and a new "SHOW_DETAIL2" flag.

Since "scontrol" can be run interactively as well,  I added a new "script" option to indicate that display of both the script and the details is wanted if the job is a batch job.

Here are the man page updates for "man scontrol".   For the "-d, --details" option:

       -d, --details
              Causes  the  show command to provide additional details where available.  Repeating the option more than
              once (e.g., "-dd") will cause the show job command to also list the batch script, if the job was a batch
              job.

For the interactive "details" option:

       details
              Causes  the  show  command  to provide additional details where available.  Job information will include
              CPUs and NUMA memory allocated on each node.  Note that on computers  with  hyperthreading  enabled  and
              SLURM  configured  to allocate cores, each listed CPU represents one physical core.  Each hyperthread on
              that core can be allocated a separate task, so a job's CPU count and task count  may  differ.   See  the
              --cpu_bind  and  --mem_bind  option  descriptions  in  srun man pages for more information.  The details
              option is currently only supported for the show job command. To also list the  batch  script  for  batch
              jobs, in addition to the details, use the script option described below instead of this option.

And for the new interactive "script" option:

       script Causes the show job command to list the batch script for batch jobs in addition to the  detail  informa-
              tion described under the details option above.

Attached are the patch file for the changes and a text file with the results of the tests I did to check out the changes.   The patches are against SLURM 2.4.0-rc1.

        -Don Albert-

so acct_policy_job_runnable will always return true.

The node_number field is normally set to the 32-bit IPv4 address of the
local node's host name.  Bill LePera, IBM, 4/18/2012

but things are closer.

The srun command formerly needed to call slurm_signal_job_step()
to load the symbol and have it accessible from the mpi plugins.
This is no longer the case due to changes in linking since 2007.

Signed-off-by: Danny Auble <da@schedmd.com>

compiling with --enable-debug

The purpose of this is so moab scripts and commands (such as 'checkjob')
have consistent access to the SUBMITHOST variable.

Conflicts:
	testsuite/expect/test21.21

Conflicts:
	src/srun/opt.c

Conflicts:
	src/srun/opt.c

Conflicts:
	src/srun/opt.c

Conflicts:
	src/srun/opt.c

Phil and I independently found a chunk of duplicate code that can be eliminated with no change to the functionality.  This is against the 2.4 branch.
Don

Conflicts:
	src/slurmctld/reservation.c