this is a corrections to some of the ligic in commit 3851f619
  that commit set a pointer to NULL, which it should not have.

Bug introduced yesterday in commit 239cfa96

Several possibly unterminated string operations
Several memory leak fixes

This is a revision of commit 72d8d9b7,
  which introduced a parsing bug

Fix several memory leaks and possible out-of-bound memory references
  reported by Coverity.

Bad array pointer for srun --no-alloc
Added function error check in srun
Memory leak in sstat

Fix several memory leaks and other high-priority errors reported by Coverity

instead of calling g_slurm_auth_get_uid again.

Add SchedulerParameters option of spec_cores_first to select specialized
    cores from the lowest rather than highest number cores and sockets.
bug 3349

Previous logic was failing if no specialized cores configured on node
  and job wanted to configure some
bug 3349

Null terminate before strchr().

This is a new message when "PrologFlags=contain" or
  "PrologFlags=alloc" is configured.
bug 3351

Cancel interactive job if Prolog failure with "PrologFlags=contain"
    configured.
bug 3351

Minor fix to commit 1e6b7522 in
  the case where user specification of specialized cores is disabled.
bug 3349

If a job specifies --core-spec and the node has identified specialized
  cores using the CpuSpecList option which are not the default cores
  (e.g. the first cores rather than the last cores on each socket),
  the the user's cores will be selected from those identified in the
  configuration.
bug 3349

This requires dealing directly with the running cluster and mucking
with it's database.

(user, account, cluster)

old sql method archive.

Was printing int64 using %ld, which generated a warning on some systems

Missed during memory conversion from 32 to 64bit. Found by clang/asan.

Only used by _gids_hashtbl_idx(); replace the string hash function
with a loop based off _get_hash_idx in slurmctld instead.

Does not appear to have ever been used.

This reverts commit 5a4b9e0c.

Options to include based on hostname or IP address were #if 0'd
by 4187ecb5.

Clean up function definition blocks while here.