Bug 5094

Bug 5094

to dictate what state of node is after reboot.

update_node_msg_t->node_state is uint32_t but we were putting a
uint16_t into it. NO_VAL16 wouldn't have gone up to the controller.

Bug 5196.

Needed for node_record_count.

Bug 5196.

This reverts commit a10454f7.

Bug 5196

Bug 5070

Bug 5468

This is a backport of commit cefc9ec1.

Bug 4918

Collapse error message on to one line when they weren't previously,
and fixup argument indentation as well while here.

find . -name '*\.[ch]' -exec sed -i s/error\(\[\ \]*\"sched:\ /sched_error\(\"/ {} \;

These calls will replace all these:
	error("sched: message...")
with:
	sched_error("message...")

This allows the _log_msg function to stop calling xstrncmp() on every
log message while holding log_lock when SchedLogLevel > 0.
This behavior has effectively removed all concurrency from slurmctld when
SchedLogLevel is enabled, and prevented larger scale systems from being able
to start up - see bug 3746 for an example of this.

Update all calling locations, and as this is a static function
change the name to _log_msg from log_msg while here.

scheduling cycle.  Primarily caused by EnforcePartLimits=ALL.

Bug 5452

This requires all calls to slurm_addto_char_list() to change to
slurm_addto_char_list_with_case().

Rather than replace all existing references, keep the existing function
name and signature, and break off the body into
slurm_addto_char_list_with_case() with the lower_case_normalization
option set to true.

Locations that need to disable this case normalization will thus have
access to this same function, just by the longer name with the extra
boolean.