CLANG was reporting a false positive. Made a function into a macro
to eliminate the error.

Its logic was flawed (lacked a level of indirection) as reported
by CLANG and was not used anyway.

limit since it behaves the same way a QOS limit would unless the QOS has
the DenyOnLimit flag set.

MaxNode limit.

if a previous test fails it doesn't cause the others to fail.

only needs to be called once.

variables.

    reference.

s_p_options_t struct.

This patch switches to using the Slurm MPI port reservation method for Cray PMI ports.

A function previous believed to be local was being used by the
perl API. It was made static in commit 57345149
This is a partial reversion of that commit.

If a job or step request GRES with a count of zero, do not even
test to see if that GRES type is defined.

job_submit plugin

Signed-off-by: Danny Auble <da@schedmd.com>