Bug 5619

Tim approved

Bug 5618

Development continues on the master branch for 19.05, but the
snapshot here should not be used and is thus being removed.

Remove the commented-out documentation as well.

# Conflicts:
#	NEWS

Bug 5608

Tim approved

If the dbd comes up after a job array has been submitted to the
controller, the controller calls _update_job_tres() which calls
assoc_mgr_set_tres_cnt_array() which allocates memory for the job's
tres_alloc_cnt. The job array gets scheduled, but job_array_split()
doesn't NULL out the pending job's tres_alloc_cnt, so both the array
task and the pending array job are pointing to the same memory. The
array task calls job_set_alloc_tres() which free's the running job's
tres_alloc_cnt and now the pending array job is pointing to bad memory
and when the array splits again the new array task tries to free
tres_alloc_cnt in job_set_alloc_tres() and segfaults.

Bug 5604

Update slurm.spec and slurm.spec-legacy as well.

This will need to be revisited perhaps link to libslurmfull.so instead
since we will need symbols not exported.

See bug 5605

The previous commit causes erroneous errors to be printed.

test2.14 was made a victim of it.

# Conflicts:
#	src/plugins/jobacct_gather/common/common_jag.c

Bug 5561.

Bug 5538

Bug 5538

This will be handled further in bug 5602

Previous behavior was confusing, and the code path hard to follow.
Rework, and clarify the established behavior in the appropriate man pages.

Bug 4514.

X11 implies Contain, and Contain is incompatible with NoHold as
the Extern step creation will race with the step launches.

Bug 5500.

This reverts commit dcc93022.

This reverts commit b9fb67d8.

CID 187777.
Bug 5593.

scan-build complains about this possibly being used uninitialized with
pthread_join(), but on review the path it identifies as causing that
is impossible. Initialize this anyways in the hopes of surppressing that
warning.

This also randomizes the backup controller port numbers which
were not being handled here for some reason.

Bug 5166

Bug 5426

Bug 5072

Change _build_path to return the xmalloc()'d string, and make sure
to free it where appropriate.

Add comment about how the processing of the PATH environment variable
here is backwards from convention.

Fixes GCC 8.2.0 warnings.

Fix some -Werror=restrict and -Werror=format= issues.

Silence GCC 8.2.0 warning.

Nothing modifies this, so don't bother making a copy of it.

Related to GCC 8.2.0 compilation fixes.