Already verified on code paths leading into here, add xassert for posterity.

CID 171465.

Their existence is already assumed (and should be enforced) elsewhere,
so do this once and simplify the remaining code.

CID 161183.

CID 171490.

CID 171485.

CID 171478.

mpi/pmi2 plugin - vestigial pointer could be referenced at shutdown with
    invalid memory reference resulting.

Coverity CID 44677

This reduces the frequency of failures due to timing issues related
to NFS down to about 1% on smd

Coverity CID 44669, 44670

Coverity CID 44699

Coverity CID 44730

Coverity CID 44966

Coverity CID 44770

No other change to logic, but this allowed some code reuse

Coverity CID 44675

Bug 4154.

Use the partition specified in the reservation, rather than
using the cluster's default.

Bug 4030.

Already handled on line 2080.

Bug 4030.

Bug 4117

Bug 4117

Files generated and left around by another user will now cause the
  test to fail gracefully and print a descriptive message

default path.

This makes it so you don't always have to put AllowedDevicesFile in your
cgroup.conf file if your etc dir is anything other than /etc/slurm.

Coverity CID 44759

No changes to logic

Coverity CID 44779

This should be redundant
Coverity CID 45168

Coverity CID 45168

Uninitialized fd value meant the open was skipped
after commit aacd6b65.

Otherwise the job step could have already ended and the WAKE RPC
  could be rejected with some misleading communication error
  being send to srun

Don't flag a job as "SPAWNED" for debugger until all process
  information is available for all pack job components.

Previous code could exit srun before all I/O was processed.

Coverity CID 44695

Coverity CID 171475