226b49a3

Test would periodically fail due to expect timing.
This seems to fix the problem

job.

channel with the slurmstepd on that node.

Bug introduced earlier today in
commit 8df024c1

Correction to bad merge of slurm-2.6 in
commit 88220a2b

Conflicts:
	src/slurmd/slurmstepd/task.c

Fix slurmstepd race condition when separate threads are reading and
modifying the job's environment, which can result in the slurmstepd failing
with an invalid memory reference. Observed at shutdown when trying
to run the task epilog and trying to read the env var:
SLURM_STEP_KILLED_MSG_NODE_ID

Previously was allocating sizeof(char *) rather than sizeof(char),
so we save some space here.

We do not want to look at the core file, so avoid generating it
and then having to manually clear it later.

Without this flag, if the configuration changes or is inconsistent
between nodes then the pack and unpack can be out of sync in terms
of what data is expected. This will let server tell the client what
data is packed.

Without this change, sstat would try to unpack accounting data
that was never packed, resulting in message unpack errors.

There were some parsing issues and the test was not as general
as it should have been

throw away initialized variable.

can handle the memory free.

Without this patch, free() is called on a random memory location
(i.e. whatever is on the stack), which can result in slurmstepd
dying and a completed job not being purged in a timely fashion.

Fix race condition in authentication credential creation that could corrupt
memory. (NOTE: This race condition has existed since 2003 and would be
exceedingly rare.)