NULL is returned if the token is not found, testing against '\0'
is wrong (although does work okay in older compilers).

Fixes new GCC 7.1 warning.

When the node isn't actually rebooted, the BootTime isn't updated and
Slurm doesn't consider that the node is returned to service, even
if slurmd is responding.

Bug 4039

This will be fixed before 17.11, but is being left as-is on 17.02.

Bug 3956.

to have 'socket=' in AuthInfo to work.

This is to make it so people don't have to update their slurmdbd.conf's
when upgrading (and to match documentation).

Continuation of last commit

Bug 4009

connection.

Bug 4009

jobcomp/elasticsearch saves/load the state to/from elasticsearch_state.  Since
the jobcomp API isn't designed with save/load state operations, the plugin
_save_state() isn't extern and not available from outside the plugin itself,
thus it is highly coupled to fini() function. This state doesn't follow the
same execution path as the rest of Slurm states, where in save_all_sate()
they are all independently scheduled. So we save it manually here on a RPC
of type REQUEST_CONTROL.

This enables that when the Primary ctld issues a REQUEST_CONTROL to the Backup
which is currently in controller mode, the Backup will save the state and when
the Primary assumes control again it can process the saved pending jobs.  The
other way around was already controlled, because when the Primary is running
in controller mode and the Backup issues a REQUEST_CONTROL, the Primary is
shutdown and when breaking the ctld main() function while(1) loop, there was
already a g_slurm_jobcomp_fini() call in place.

Bug 3908

Bug 3973.

Prevent the possibility (never observed) of the ping count going
negative

When more than 1 ping cycle is spawned simultaneously (for instance
REQUEST_PING + REQUEST_NODE_REGISTRATION_STATUS for the selected nodes),
we do not track a separate ping_start time for each cycle. When ping_begin()
is called, the information about the previous ping cycle is lost. Then when
ping_end() is called for the first of the two cycles, we set ping_start=0,
which is incorrectly used to see if the last cycle ran for more than
PING_TIMEOUT seconds (100s), thus incorrectly triggering the:

 error("Node ping apparently hung, many nodes may be DOWN or configured "
       "SlurmdTimeout should be increased");

Bug 3914

Bug 3941.

44e2b1a9 and where the functionality was promptly removed a few days later
in 51076871.  Thanks to Artem Polyakov for pointing out the history :).

 -- Add slurm.conf configuration parameters SlurmctldSyslogDebug and
    SlurmdSyslogDebug to control which messages from the slurmctld and
    slurmd daemons get written to syslog.
 -- Add slurmdbd.conf configuration parameter DebugLevelSyslog to
    control which messages from the slurmdbd daemon get written to syslog.
bug 3933

ee84f5c1.

like slurm_switch_ops_t instead of the new dynamic_plugin_data_t.

Bug 4025

Reported by Coverity, CID 45140 and 45141

pack_job_id was being reported as pack_job_offset

Get rid of any race conditions and call anything that was in
_pre_task_privileged from the parent instead of the child.

NOTE: This should be safe as we don't execute the task until after
_exec_wait_child_wait_for_parent is signaled which happens after all this is
long over.

Bug 3865

Fix regression in commit e5c05549 that would put the stepd pid into the memory cgroup instead of the task's pid.

Beforehand this would put the result of getpid() into the cgroup.  Before
e5c05549 this was done in the child of the fork which would get you
the task's pid, but moving it to run in the parent broke this logic.

What this patch does is adds pid to the input parameters of
task_g_pre_launch_priv making it so we could use the correct pid.

Regression in commit afeca4e2. Bug 4026.

Bug 3953

Pretty much fix the entire purpose of this max_agent_queue.

Bug 3159