Simplify the step prefix process
and move it as early as possible in the step.

Since NO_VAL = SLURM_BATCH_SCRIPT, the else statement would only compare
the job_id and not the step_id, thus when a batch step was removed all
the steps from that job would be removed too. Then when attempting to
remove the extern step in the next iteration, it was already removed
and we were incorrectly erroring out.

Bug 4458.

Missed some debug statements

Bug 4455

This makes it so if the user doesn't request any GRES they are denied
all the GRES with devices.  Before this would only happen for the GRES
type the user requested.

Bug 4455

Fix to purge old jobs using burst buffer if slurmctld daemon restarted
    after the job's burst buffer work was already completed.

Bug 4455

Bug 4378.

Fix memory leak of MailDomain configuration string when slurmctld daemon
   is reconfigured.
bug 4272 (comment 35)

Bug 4384

Bug 4450

the libslurmfull.

In my testing with the cray job_submit plugin enabled it caused a
delay of the last step most likely because the gres wasn't ready quick
enough.

This reverts commit f9977ee5.

Since it's not needed in 17.11

slurm_load_job() prior to 17.11 returns the error code in errno and not
in rc.  With the addition of 47175901 if a job is removed from memory
before sbatch checks for the job again, sbatch could get in an loop
checking for the job. This only happens if you have a very small
MinJobAge (<10) -- which is not recommended.

Bug 4445

Bug 4444

Update slurm.spec and slurm.spec-legacy as well

Bug 4323

Bug 4299

Bug 4299

Amend commit 4b76750a.

Bug 4299

Bug 4408.

bug 4442

Bug 4440