Previous logic would close a bad file pointer, but this corrects the
changes in commit: 2268057f

Another good find by Coverity!

Good find by Coverity: pointer returned to data on local function stack.
Not every actually used, but a good find anyway.

Contents undefined otherwise

FILE descriptor used after close

account or wckey.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

This modifies code added in Slurm version 16.05 so that it works
properly with a change made in version 15.08 with respect to the
definition of SLURMSTEPD_MEMCHECK, see commit
c4d0d306

Previous logic could hang the slurmstepd in an infinite loop

slurmctld could die if a job existed in completing state with an invalid/defunct
partition name and "scontrol reconfigure" is run.

Make sure that /proc/#/stat file is NULL terminated to avoid
having sscan() go off the end of a buffer.
bug 2234

I've created this patch which we're using in-house to allow snc4+cache and reject other snc4 combinations.

Fix for tracking job resource allocation when slurmctld is reconfigured
    while Cray Node Health Check (NHC) is running. Previous logic would fail to
    record the job's allocation then perform release operation upon NHC
    completeion, resulting in underflow error messages.
bug 2353

While here, mark options const, and add leading underscore to denote this
as a static function (only called within hostlist.c). Also change strcmp
to xstrcmp.

Commit a6ffef22 changed this function and would alter the input hn,
which led to subsequent calls to the function having wrong prefix
lengths for that hostrange precluding it from matching correctly.

Bug 2558.

Preserving the original subject has it's pro's, both for backward compatibility and for spotting failed jobs between thousands of successful jobs.
bug 1611

seff crashes when Data::Dumper is not installed (and that one is not required by the slurm-seff rpm). It's not used so it doesn't need to be loaded.
bug 1611

and error files.