CID 177947

by removing redundant checks for WAIT_ states. If the job was already
released then the state_reason won't have the WAIT_HELD states.

Coverity CID 44862, 44863

Coverity CID 45160

Coverity CID 45147

Coverity CID 44874

2266778f

When creating a reservation, correct logic to ignoring job allocations on
    request.
bug 4172

When creating a reservations, validate the CoreCnt specification matches
    the number of nodes listed.
bug 4172

Test for node count being too large
Avoid printing two error messages in "scontrol create reservation"
  node count value is illigal.

Bug 4172

was missed in 3e3b3c97

which isn't allowed.

Bug 4235

Starting from glibc-2.25 the macros major and minor are only available
from sys/sysmacros.h. This patch uses an autoconf macro to detect the
location and includes the header accordingly.

Bug 3982.

to prev commit 33e352a6

Before:
When a reservation goes away the reservation pointer is removed from
every pending job and the job could run outside the requested
reservation.

Now:
When the reservation goes away, pending jobs requesting the reservation
are put into a held state unless the reservation has the
NO_HOLD_JOBS_AFTER_END flag.

Bug 4214

In a job allocation spanning KNL and non-KNL nodes and requiring a reboot,
    do not attempt to set default NUMA or MCDRAM modes on non-KNL nodes.
bug 4205

The "sort" command output ordering depends upon the node names.
This change makes the test work with any node names.

Bug 3396.

RHEL names the package lua-devel, SuSE names it lua51-devel.

Only used for netloc_to_topology, designed for use on SGI ICE
systems. It will still build if <netloc.h> is detected.

Used with TotalView, but untested in a long time and likely
does not work. Please send a patch if you needs this back.

Note that this is a little confusing to stare at - the logic
for what is the default is inverted between slurm's macro
and the now-standardized bcond macros.

Otherwise the BuildRequires sections are ignored, and slurm will
attempt to build in a potentially-broken environment.

Move their service files over with them.
Make slurmdbd unconditionally include its own service file.

No real value in having them split; you're going to need them on
all systems anyways.