It turns out that autogen.sh is just going to put these right back in.

This reverts commit cb37e64864b706b7c14851d03e509ef237db1813.

config.h.in: <inttypes.h> required and includes PRIu64.
smd_ns.h: remove local bool redefinition. Always pick stdbool.h. Alphabetize.
testsuite: cleanup includes as well while here.

Goodbye to:
HAVE_DIRENT_H HAVE_ERRNO_H HAVE_FLOAT_H HAVE_HSTRERROR HAVE_LIMITS_H
HAVE_MCHECK_H HAVE_MTRACE HAVE_NETDB_H HAVE_PTHREAD_H
HAVE_SECURITY_PAM_APPL_H HAVE_SOCKET_H HAVE_STRSIGNAL HAVE_SYSINT_H
HAVE_SYS_IPC_H HAVE_SYS_SEM_H HAVE_SYS_SHM_H HAVE_VALUES_H

<syslog.h> already in use throughout Slurm.

Also remove #include "config.h" where no longer required.

C99 says this keyword exists, stop hiding it behind a macro.

Continuation on previous patch, but for files that require review.

Most of these were just using a local #if _DEBUG and/or protecting against
multiple inclusion with #ifndef _PROTECT_H; #define _PROTECT_H.

Some also have __APPLE__ or __FreeBSD__ blocks, but those are not in config.h.

Found semi-automatically with:
for a in $( for i in $(grep -r \"config.h\"|cut -f 1 -d : ) ; \
do echo -n "$i "; grep '#if' $i | wc -l  ; done \
|grep \ 0 |cut -f 1 -d ' ' ) ; do vim $a ; done

POSIX, Linux, FreeBSD all agree setpgrp(0, 0) is equivalent to setpgid(0, 0),
and setpgrp() is deprecated in POSIX.

As of this commit these are all removed from src:
HAVE_UNISTD
WITH_PTHREAD
HAVE_LIMITS
HAVE_STRING
HAVE_SYS_TYPES_H
HAVE_SYS_SOCKET_H

Continue sorting system includes and un-#ifdef'ing a few additional headers.
(HAVE_STRING, HAVE_UNISTD, HAVE_LIMITS, HAVE_PTHREAD).

Unconditionally define _GNU_SOURCE when used. Should audit use of this further
and possibly define this in config.h directly along with POSIX macros.

Remove last vestige of src/common/malloc.[ch].

Needed for isspace()

Anything that is contigent on "if (!HAVE_MALLOC)" is a bad idea. Plus, these
aren't actually used by anything. Remove files and stop building them.

Always include "config.h".

Rearrange standard library includes while here, and clean up some additional
ifdef contamination missed on the first pass.

Cleanup the other directories in src/.

Remove WITH_PTHREAD from configure as well while here.

Require <pthread.h> and cleanup #ifdef blocks.

Sort system includes.

Remove local mutex_* macros. Require <pthread.h> and fixup includes.

Remove list_mutex_* macros. Require <pthread.h> and remove WITH_PTHREAD

Remove cbuf_mutex_* macros. Require <pthread.h> and remove WITH_PTHREAD

Replace all __CURRENT_FUNC__ references with c99 __func__

Remove NULL and bool definitions, use <stddef.h> and <stdbool.h> instead.

AF_SLURM => AF_INET; AF_INET is already commonly used.

SLURM_INADDR_ANY macro never used.

No functional change in theory. Cleanup headers to reduce the mostly-useless
for some time now.

1) Remove common/{getopt.[ch],getopt1.c} files and remove from build. Use
   C99-required functions from <unistd.h> and <getopt.h>.

2) <inttypes.h> is required by C99 and has been required for some time. Remove
   #ifdef blocks and replace some older <stdint.h> includes.

3) <pthread.h> isn't optional at this point. PTHREAD_MUTEX_INITIALIZER is
   required throughout.

4) Use <limits.h> instead of <values.h> or <float.h>

5) <string.h> is required by C99. Remove long-deprecated <strings.h> includes.

# Conflicts:
#	src/plugins/select/cray/select_cray.c
#	testsuite/expect/test1.84

    for better robustness.  This cray/select plugin code has
    been modified to remove a possible timing window where two
    aeld pthreads could exist, interfering with each other through
    the global aeld_running variable.

    An additional validity check has been added to the data provided
    to aeld through an alpsc_ev_set_application_info() call.
    If an error is returned from that call, only certain errors
    need the current socket connection closed to aeld and a new
    connection established.  Other error returns will log an
    error message and keep the current session established with
    aeld.