correct precompile directive to test for variable definition rather
than true value. Correction to commit 01b658a3

Make sure strings are NULL terminated.
Prolems reported by Coverity

This adds support for burst buffer re-issue of pre-load operation
when slurmctld restarts with job in configuring state. Also copy
NEWS item to v16.05.

Prevent job stuck in configuring state if slurmctld daemon restarted while
    PrologSlurmctld is running.
bugs 2789 and 2810

can work on a BGAS node.

Bug 2806

Except return 0 if using the -u argument. Bug introduced by addb3574,
fix bug 2330 differently while solving bug 2807.

of continuously printing the message over and over as the problem will
most likely not resolve itself.

Bug 2797

Previous logic would close a bad file pointer, but this corrects the
changes in commit: 2268057f

Another good find by Coverity!

Good find by Coverity: pointer returned to data on local function stack.
Not every actually used, but a good find anyway.

Contents undefined otherwise

FILE descriptor used after close

account or wckey.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

Valgrind's drd tool reported a race condition on a variable, so
mutex was added to wrap it. The chances of this causing a problem
are nill, but this makes it zero.

This modifies code added in Slurm version 16.05 so that it works
properly with a change made in version 15.08 with respect to the
definition of SLURMSTEPD_MEMCHECK, see commit
c4d0d306

Previous logic could hang the slurmstepd in an infinite loop

slurmctld could die if a job existed in completing state with an invalid/defunct
partition name and "scontrol reconfigure" is run.

Make sure that /proc/#/stat file is NULL terminated to avoid
having sscan() go off the end of a buffer.
bug 2234

I've created this patch which we're using in-house to allow snc4+cache and reject other snc4 combinations.

Fix for tracking job resource allocation when slurmctld is reconfigured
    while Cray Node Health Check (NHC) is running. Previous logic would fail to
    record the job's allocation then perform release operation upon NHC
    completeion, resulting in underflow error messages.
bug 2353