- 06 Jan, 2014 3 commits
-
-
Morris Jette authored
Without this patch, the job's RunTime includes its RunTime from before it's prior suspend (i.e. the job's full RunTime rather than just the RunTime of the requeued job).
-
Morris Jette authored
-
Morris Jette authored
-
- 27 Dec, 2013 2 commits
-
-
Filip Skalski authored
Hello, I think I found another bug in the code (I'm using 2.6.3 but I checked the 2.6.5 and 14.03 versions and it's the same there). In file sched/backfill/backfill.c: 1) _add_reservation function, from lines 1172: if (placed == true) { j = node_space[j].next; if (j && (end_reserve < node_space[j].end_time)) { /* insert end entry record */ i = *node_space_recs; node_space[i].begin_time = end_reserve; node_space[i].end_time = node_space[j].end_time; node_space[j].end_time = end_reserve; node_space[i].avail_bitmap = bit_copy(node_space[j].avail_bitmap); node_space[i].next = node_space[j].next; node_space[j].next = i; (*node_space_recs)++; } break; } I draw a picture with `node_space` state after 2 iterations (see attachment). In case where the new reservation is fully inside another reservation, then everything is OK. But if the new reservation spans multiple existing reservations then the `end entry record` is not created. This is because only the newly created `start entry record` is checked. Easy fix would be to change the if into a loop, for example: if (placed == true) { while((j = node_space[j].next) > 0) { if (end_reserve < node_space[j].end_time) { //same as above break; } } break; } 2) You could also change line 612: node_space = xmalloc(sizeof(node_space_map_t) * (max_backfill_job_cnt + 3)); To `(max_backfill_job_cnt * 2 + 1)` , since each reservation can add at most two entries (check at line 982 should never execute). At the moment, in a worst case scenario this only checks half of the max_backfill_job_cnt. NOTE: However this is all based on the assumption, that it is not done on purpose to speed up the calculations and trading some of the accuracy (especially point 2). Best regards, Filip Skalski
-
Morris Jette authored
-
- 25 Dec, 2013 1 commit
-
-
David Bigagli authored
-
- 23 Dec, 2013 3 commits
-
-
Morris Jette authored
-
Morris Jette authored
-
David Bigagli authored
-
- 21 Dec, 2013 2 commits
-
-
Danny Auble authored
-
Danny Auble authored
-
- 20 Dec, 2013 6 commits
-
-
Danny Auble authored
-
Danny Auble authored
-
Danny Auble authored
runjob_mux.
-
Danny Auble authored
0c00d359
-
Danny Auble authored
for better debug
-
Danny Auble authored
midplane block that starts on a higher coordinate than it ends (i.e if a block has midplanes [0010,0013] 0013 is the start even though it is listed second in the hostlist).
-
- 19 Dec, 2013 1 commit
-
-
Morris Jette authored
It has been changed to improve the calculated value for pending jobs and use the actual node count value for jobs that have been started (including suspended, completed, etc.) bug 549
-
- 18 Dec, 2013 7 commits
-
-
Danny Auble authored
that spans multiple midplanes the cnodes are correctly accounted for that are in error.
-
Danny Auble authored
-
Danny Auble authored
-
Danny Auble authored
-
Danny Auble authored
being in error.
-
Danny Auble authored
-
Morris Jette authored
Note that each job's node allocation is counted separately. bug 548
-
- 17 Dec, 2013 2 commits
-
-
Danny Auble authored
-
Danny Auble authored
will return ENOTCONN and not initialize the addr_str causing valgrind errors.
-
- 16 Dec, 2013 4 commits
-
-
Morris Jette authored
-
Morris Jette authored
-
Hughes, Doug authored
This allows multiple job ids to hold, uhold, resume, suspend, release, etc.
-
Morris Jette authored
-
- 14 Dec, 2013 3 commits
-
-
Danny Auble authored
226b49a3
-
Morris Jette authored
Test would periodically fail due to expect timing. This seems to fix the problem
-
Danny Auble authored
-
- 13 Dec, 2013 4 commits
-
-
Danny Auble authored
-
Morris Jette authored
-
Morris Jette authored
Fix slurmstepd race condition when separate threads are reading and modifying the job's environment, which can result in the slurmstepd failing with an invalid memory reference. Observed at shutdown when trying to run the task epilog and trying to read the env var: SLURM_STEP_KILLED_MSG_NODE_ID
-
Morris Jette authored
We do not want to look at the core file, so avoid generating it and then having to manually clear it later.
-
- 12 Dec, 2013 2 commits
-
-
Morris Jette authored
Without this change, sstat would try to unpack accounting data that was never packed, resulting in message unpack errors.
-
Morris Jette authored
There were some parsing issues and the test was not as general as it should have been
-