Mostly to split long lines

    I am sending the latest update of my NPPCU-support patch for Slurm 2.5.0.  As before, this patch is applied over my basic BASIL 1.3 support patch.  The reason for this latest version is that it came to my attention, that certain jobs that should have been rejected by Slurm were allowed through.  I then further noticed that this would cause the backfill algorithm to slow down dramatically (often not being able to process any other jobs).
     The cause of the problem was that when I introduced the functionality into Slurm to properly set the "nppcu" (number of processors per compute unit) attribute in the XML reservation request to ALPS, I didn't also adjust the tests earlier in the code that eliminate nodes from consideration that do not have sufficient resources.  In other words, jobs that would exceed the absolute total number of processors on the node would be rejected as always (this is good).  Jobs that required the reduced number of "visible" processors on the node or less were allocated and worked fine (this is good).  Unfortunately, jobs that needed a number of processors somewhere in between these limits (let's call them the soft and hard limits) were allowed through by Slurm.  Making matters worse, when Slurm would subsequently try to request the ALPS reservation, ALPS would correctly reject it but Slurm would keep trying--this would then kill the backfilling.  In my opinion, these jobs should have been rejected from the onset by Slurm as they are asking for more processors per node than can be supplied.  If the user wants this number of processors they should specify the "--ntasks-per-core=..." (in our case "2" as that is the full number of hardware threads per core).  Obviously, this problem only appeared when I used CR_ONE_TASK_PER_CORE in the slurm.conf as I had modified the code to set nppcu to 1 when Slurm was configured with that option and the user didn't explicitly specify a different value.
    The patch appears to be working well for us now and so I am submitting it to you for your review.

A fix for this problem will require more study. This one causes
xassert when an attempt to start a job results in it not being
started by sched/backfill due to the partition time limit.

Fix sched/backfill logic to initiate jobs with maximum time limit over the
partition limit, but the minimum time limit permits it to start.
Related to bug 251

Fix for bug 224

Conflicts:
	src/plugins/priority/multifactor/priority_multifactor.c

Hi this is an update of the Bash completion script that I submitted  a while ago.

Conflicts:
	doc/html/platforms.shtml
	doc/html/team.shtml

WIthout this patch, when the slurmd cold starts or slurmstepd
terminates abnormally, the job script file can be left around.
bug 243

Previously such a job submitted to a DOWN partition would be queued.
bug 187

Conflicts:
	doc/man/man1/sbatch.1

Fix spank_option_getopt in local context

In local context (srun, sbatch, salloc), spank_option_getopt() would
always return that an option was found due to a missing check for
spopt->found in spank_option_getopt.

This patch fixes the issue.