NULL check is implied already, and this format is prevalent.

Also remove unnecessary casts while tidying up.

Change to plugrack_new_t to make sure every location is caught.

Remove plugrack_set_major_type().

Was never used to enable the paranoid behavior.

No functional change, aside from switching to __func__ in log messages.

Also switch to xmalloc pattern of:
    int *data = xmalloc(sizeof(*data));
while cleaning these up.

Remove now-unused variables missed in e7a34806/c10f2cf0.

Include explicit values so some can be removed in successive commits.

Missed in BlueGene code removal.

# Conflicts:
#	src/slurmctld/read_config.c

Bug 6302
Bug 6229

this new function adds logic to validate that a job's gres request is
still valid after slurmctld restart or reconfiguration. specifically
if a job allocation includes GRES associated with specific Files then
kill the job if the GRES count changes (say the job is allocated GPUs
and the slurmctld configuration changes to remove those GPUs, so the
job and node bitmaps are different sizes).

This prevents a slurmctld abort if a job was running on a node
  using all gres/gpu and the node configuration changed to have
  fewer gres/gpu. slurmctld would abort on restart with the new
  configuration.

Previous logic was calculating a node's total cores and total threads
in multiple locations rather than doing the calculation only in the
function gres_plugin_node_config_validate().

string.

Bug 6169